Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add securityGroups, availabilityZones, and hostedZoneId to ELBs #3826

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Add securityGroups, availabilityZones, and hostedZoneId to ELBs #3826

merged 2 commits into from
Apr 24, 2024

Conversation

tas50
Copy link
Member

@tas50 tas50 commented Apr 23, 2024 •
edited
Loading

This is pretty important information for a load balancer

aws.elb.loadBalancers.first: {
  securityGroups: [
    0: aws.ec2.securitygroup id="sg-1234567" name="default" region="us-west-2" vpc.id="vpc-1234567"
  ]
  hostedZoneId: "12345678910"
  availabilityZones: [
    0: "us-west-2b"
    1: "us-west-2a"
  ]
}

@tas50
Add securityGroups and availabilityZones to ELBs
dec8755 
This is pretty important information for a load balancer

Signed-off-by: Tim Smith <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 23, 2024 •
edited
Loading

Test Results

2 980 tests   2 979 ✅  1m 19s ⏱️
  329 suites      1 💤
   23 files        0 ❌

Results for commit bdda454.

♻️ This comment has been updated with latest results.

@tas50
Add hostedZoneId as well
bdda454 
Signed-off-by: Tim Smith <[email protected]>
@tas50 tas50 changed the title Add securityGroups and availabilityZones to ELBs Add securityGroups, availabilityZones, and hostedZoneId to ELBs Apr 23, 2024
arlimus
arlimus approved these changes Apr 24, 2024
View reviewed changes
Copy link
Member

@arlimus arlimus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing!!

@arlimus arlimus merged commit 89f8bf2 into main Apr 24, 2024
15 checks passed
@arlimus arlimus deleted the tas50/elb branch April 24, 2024 00:58
@github-actions github-actions bot locked and limited conversation to collaborators Apr 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@arlimus arlimus arlimus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tas50 @arlimus