🧹 default to MQL asset context #3805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had this feature-flag since v7, aimed to make it the default in v8. Until now, it has not been mainlined. This is changing today. Compiling with context is generally very helpful and provides nice auto-complete on embedded resources (similar to how you can access embedded fields in golang structs). There is more work to be done, namely that we want to tie the context of the connection to the MQL execution itself. This will allow us to call fields without constantly refering to the global context in the future. (i.e. instead of `docker.file.sth`, once you connect to a Dockerfile you can just call `sth`). For this reason, we retain the feature-flag and will complete its functionality in this major release.
Test Results2 977 tests ±0 2 976 ✅ ±0 1m 40s ⏱️ +8s Results for commit 2f5d4af. ± Comparison against base commit 6459c85. This pull request removes 3 and adds 3 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Merged
These were added in v7, but unfortunately we had to break the compatibility in v9. We will regain this ability, once cross-provider calls (in the new model) are added back. Signed-off-by: Dominik Richter <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had this feature-flag since v7, aimed to make it the default in v8. Until now, it has not been mainlined.
This is changing today. Compiling with context is generally very helpful and provides nice auto-complete on embedded resources (similar to how you can access embedded fields in golang structs).
There is more work to be done, namely that we want to tie the context of the connection to the MQL execution itself. This will allow us to call fields without constantly refering to the global context in the future. (i.e. instead of
docker.file.sth, once you connect to a Dockerfile you can just callsth). For this reason, we retain the feature-flag and will complete its functionality in this major release.Note: I deactivated one level of functionality which had been degraded since v9, namely: cross-provider calling of MQL queries. We are restoring this with provider provider initialization (which hasn't been added yet). The release of v9 had removed this because providers were then individually packaged and structured and we hadn't yet had the time to migrate this functionality. Without the change in this PR, these types of calls/usages all resulted in a panic, jfyi