🐛 Change data conversion to allow for nil resources. Fix azure monitor as an example

providers-sdk/v1/plugin/runtime.go

@@ -239,9 +239,14 @@ func GetOrCompute[T any](cached *TValue[T], compute func() (T, error)) *TValue[T
 
 	x, err := compute()
 	if err != nil {
-		res := &TValue[T]{Data: x, Error: err}
+		// why do we always set to IsNull here?
+		res := &TValue[T]{State: StateIsSet | StateIsNull}
+		// Note: if we're getting back a NotReady error, it means the computed
+		// resource is not present and we should return nil.
+		// To avoid panics down the stack, we only set the data and err if it's anything other than a NotReady error
 		if err != NotReady {
-			res.State = StateIsSet | StateIsNull
+			res.Data = x
+			res.Error = err
 		}
 		return res
 	}

providers/azure/resources/monitor.go

@@ -5,7 +5,6 @@ package resources
 
 import (
 	"context"
-	"errors"
 
 	"go.mondoo.com/cnquery/v9/llx"
 	"go.mondoo.com/cnquery/v9/providers-sdk/v1/plugin"
@@ -268,28 +267,28 @@ func (a *mqlAzureSubscriptionMonitorServiceActivityLog) alerts() ([]interface{},
 
 func (a *mqlAzureSubscriptionMonitorServiceLogprofile) storageAccount() (*mqlAzureSubscriptionStorageServiceAccount, error) {
 	if a.StorageAccountId.IsNull() {
-		return nil, errors.New("diagnostic settings has no storage account")
+		return nil, plugin.NotReady
 	}
 	if a.StorageAccountId.Error != nil {
 		return nil, a.StorageAccountId.Error
 	}
 	storageAccId := a.StorageAccountId.Data
 	if storageAccId == "" {
-		return nil, errors.New("diagnostic settings has no storage account")
+		return nil, plugin.NotReady
 	}
 	return getStorageAccount(storageAccId, a.MqlRuntime, a.MqlRuntime.Connection.(*connection.AzureConnection))
 }
 
 func (a *mqlAzureSubscriptionMonitorServiceDiagnosticsetting) storageAccount() (*mqlAzureSubscriptionStorageServiceAccount, error) {
 	if a.StorageAccountId.IsNull() {
-		return nil, errors.New("diagnostic settings has no storage account")
+		return nil, plugin.NotReady
 	}
 	if a.StorageAccountId.Error != nil {
 		return nil, a.StorageAccountId.Error
 	}
 	storageAccId := a.StorageAccountId.Data
 	if storageAccId == "" {
-		return nil, errors.New("diagnostic settings has no storage account")
+		return nil, plugin.NotReady
 	}
 	return getStorageAccount(storageAccId, a.MqlRuntime, a.MqlRuntime.Connection.(*connection.AzureConnection))
 }