Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ add labels and annotations to k8s namespace #1395

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Conversation

imilchev
Copy link
Member

we seems to have forgotten to add those. I added them for completeness (also because we want to visualize them):

cnquery> k8s.namespaces[0].labels
k8s.namespaces[0].labels: {
  kubernetes.io/metadata.name: "cert-manager"
}
cnquery> k8s.namespaces[0].annotations
k8s.namespaces[0].annotations: {
  kubectl.kubernetes.io/last-applied-configuration: "{\"apiVersion\":\"v1\",\"kind\":\"Namespace\",\"metadata\":{\"annotations\":{},\"name\":\"cert-manager\"}}
"
}

Copy link
Member

@chris-rock chris-rock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @imilchev

@chris-rock chris-rock merged commit dcec917 into v8 Jul 27, 2023
9 checks passed
@chris-rock chris-rock deleted the ivan/k8s-ns-labels branch July 27, 2023 11:47
@github-actions github-actions bot locked and limited conversation to collaborators Jul 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants