⭐ add assume role support for aws #1340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vjeffrey
force-pushed
the
vj/assume-role-aws
branch
from
1b7680c
to
c2558ab
Compare
jaym
reviewed
Jul 12, 2023
motor/providers/aws/provider.go
Outdated
| return func(o *stscreds.AssumeRoleOptions) {} | ||
| } | ||
|
|
||
| func WithAssumeRole(roleArn string, defaultCfg aws_sdk.Config, externalId string) ProviderOption { |
There was a problem hiding this comment.
[super nit] the order of the arguments seems maybe weird. Like why is defaultCfg between roleArn and externalId
jaym
approved these changes
Jul 12, 2023
vjeffrey
force-pushed
the
vj/assume-role-aws
branch
from
c2558ab
to
6c68583
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add assume role support for aws
go run apps/cnquery/cnquery.go shell aws --option role-arn=ROLEARNgo run apps/cnquery/cnquery.go shell aws --option role-arn=ROLEARN --option external-id=EXTERNALID