🧹 Do not fetch trails if they are not part of the account. #1185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Preslav <[email protected]>
vjeffrey
reviewed
May 4, 2023
| // we skip trails that are not coming from the account that is being scanned | ||
| // such trails are organization trails, created from another (master) acc in the org | ||
| trailArn := core.ToString(trail.TrailARN) | ||
| if !strings.Contains(trailArn, acc) { |
There was a problem hiding this comment.
is there any information we can gather about organization trails? we should be able to work around not being able to fetch a kms key or log group, since keys can be deleted anytime, it's always a problem we can run into
There was a problem hiding this comment.
yeah, we can also just not err out if the key or the log group are not found.
re the org trails: there's a bool on the trail that indicates what it is. i am not sure if we can use it since i'd assume we want to show that trail in the master acc it has been created from
vjeffrey
approved these changes
May 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1184
We cannot query information about a trail (log group, kms key, etc) if that trail is coming from another account. In that case, we should just skip it