Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 Test provided cert/pass when creating an ms365 connection. #1162

Merged
merged 2 commits into from
May 2, 2023

Conversation

preslavgerchev
Copy link
Contributor

@preslavgerchev preslavgerchev commented Apr 19, 2023

Fixes #1113

image

~/go/bin/cnquery shell ms365 --certificate-path ~/cert-no-pk.pem --client-id xxxxxxx --tenant-id xxxxxxxx
→ loaded configuration from /Users/preslavgerchev/.config/mondoo/mondoo.yml using source default
→ discover related assets for 1 asset(s)
→ resolved assets resolved-assets=0
x could not connect to asset error="could not parse provided certificate at /Users/preslavgerchev/azure-cert.pem: found no private key" asset=
FTL could not resolve assets

@misterpantz
Copy link
Contributor

Hi! Could we provide some help on resolving this? I was thinking we could send them to this topic in the docs?
https://mondoo.com/docs/platform/saas/ms365/

@tas50
Copy link
Member

tas50 commented May 2, 2023

Hi! Could we provide some help on resolving this? I was thinking we could send them to this topic in the docs? https://mondoo.com/docs/platform/saas/ms365/

We'd want cnspec/CLI docs to send them to for this one.

Copy link
Member

@imilchev imilchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@preslavgerchev preslavgerchev merged commit dbd2ae2 into main May 2, 2023
@preslavgerchev preslavgerchev deleted the preslav/validate-pem-azure-ms365 branch May 2, 2023 09:26
@github-actions github-actions bot locked and limited conversation to collaborators May 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate provided pem files to ensure they include private key
5 participants