Skip to content

Commit

Permalink
🧹 Exclude storage containers from FF scanning.
Browse files Browse the repository at this point in the history
Signed-off-by: Preslav <[email protected]>
  • Loading branch information
preslavgerchev committed Jul 15, 2024
1 parent cc83472 commit 0f01776
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion providers/azure/resources/discovery.go
Original file line number Diff line number Diff line change
Expand Up @@ -169,14 +169,17 @@ func Discover(runtime *plugin.Runtime, rootConf *inventory.Config) (*inventory.I
}
assets = append(assets, mariaDbServers...)
}

if stringx.ContainsAnyOf(targets, append(matchingTargets, DiscoveryStorageAccounts)...) {
accs, err := discoverStorageAccounts(runtime, subsWithConfigs)
if err != nil {
return nil, err
}
assets = append(assets, accs...)
}
if stringx.ContainsAnyOf(targets, append(matchingTargets, DiscoveryStorageContainers)...) {

// FIXME: bring back the storage containers as as part of FF scanning once we can do parallel scanning
if stringx.ContainsAnyOf(targets, DiscoveryAll, DiscoveryStorageContainers) {
containers, err := discoverStorageAccountsContainers(runtime, subsWithConfigs)
if err != nil {
return nil, err
Expand Down

1 comment on commit 0f01776

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.

Benchmark suite Current: 0f01776 Previous: afec124 Ratio
BenchmarkScan_SingleAsset - ns/op 3281441073 ns/op 2079316883 ns/op 1.58

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.