-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add excluded subclass of assertions for ICD10 #7111
Conversation
Sounds good, I am working on this, I started a spreadsheet |
🚀 🚀 🚀 🚀 🚀 This is fantastic work @nicolevasilevsky amazing! Can we discuss during next 1:1 or tech call? |
yes! |
If this is work that I will eventually be a part of as we transition tech tasks I would like to be on the call :) Also, @nicolevasilevsky what is the source you are using to view ICD10CM? And what criteria is being used whether the subclass axiom should be excluded? I was wondering about this for example because I thought that for: |
@nicolevasilevsky lets push discussion to tech call! |
Having the discussion on the tech call sounds great! Keep in mind the next tech call that we will all be available for (Nico, Nicole, Trish) is not until Feb 2. |
Thats ok, this is not urgent. |
@matentzn I am done reviewing this spreadsheet. Do I need to create a new ticket? I will manually add the superclass assertions that are correct - add my ORCID and ICD10 ID as source. I will do this on a separate PR. I'll add this to the tech call agenda. Related ticket: monarch-initiative/mondo-ingest#400 |
note: the PR to add new superclasses (#7332) is merged |
Conclusion: for now we will create a blanket 'exclude subclass of' for everything and add a 'not verified' tag, and as we curators should keep an eye out for these 'not verified' tags and review them if we come across them during other work. closing this. |
This is a test, but real, PR which adds 47 "excluded subclass of" assertions from ICD10CM.
The original table can be seen here: https://github.com/monarch-initiative/mondo-ingest/blob/8e9ca4be6b9623ddf715e3426954070416fa9eac/src/ontology/reports/icd10cm.subclass.added.robot.tsv
@nicolevasilevsky volunteered to take a first look. As this is the first PR of its kind, we should be a bit critical:
We should at the very least to some spot checking, but I feel rigour will pay off, at least for the first PR.