-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Exclusion tables #32
Conversation
joeflack4
commented
Jun 21, 2022
•
edited
Loading
edited
571b416
to
d96a4d2
Compare
7b9b5c2
to
b2c42d2
Compare
src/scripts/exclusion_term_expansion/exclusion_term_expansion.py
Outdated
Show resolved
Hide resolved
b2c42d2
to
e187482
Compare
src/scripts/exclusion_term_expansion/exclusion_term_expansion.py
Outdated
Show resolved
Hide resolved
src/scripts/exclusion_term_expansion/exclusion_term_expansion.py
Outdated
Show resolved
Hide resolved
Nice looking work. I think we should have a |
Re: |
675cc90
to
e9807bb
Compare
src/scripts/exclusion_term_expansion/exclusion_term_expansion.py
Outdated
Show resolved
Hide resolved
src/scripts/exclusion_term_expansion/exclusion_term_expansion.py
Outdated
Show resolved
Hide resolved
src/scripts/exclusion_term_expansion/exclusion_term_expansion.py
Outdated
Show resolved
Hide resolved
src/scripts/exclusion_term_expansion/exclusion_term_expansion.py
Outdated
Show resolved
Hide resolved
src/scripts/exclusion_term_expansion/exclusion_term_expansion.py
Outdated
Show resolved
Hide resolved
src/scripts/exclusion_term_expansion/exclusion_term_expansion.py
Outdated
Show resolved
Hide resolved
b5da25f
to
dc40b8f
Compare
Looked at this today, @joeflack4 still working on adding the relevant signature logic discussed above. |
|
6ba68b0
to
c779ef4
Compare
ab841ad
to
5ad9c52
Compare
8765217
to
7598248
Compare
- Updates to existing exclusion query tables: Added header, including missing columns, but did not yet populate data in those columns. - Added new exclusion query tables for the rest of the ontologies. - Added exclusion results for ICD10CM. - Added Python script to work w/ these tables: term_range_expansion.py - Added SPARQL Jinja2 scripts to be called by Python script. - Added make goal to call Python script. - requirements: Updated Python requirements files to include OAK.
- Update: Make goal: Fixed .owl file dependency using 'relevant signature' file. - Update: ICD10CM exclusion table TSV: Replaced arbitrarily expanded list back to original intensional list given by curators. - Update: Script now uses --relevant-signature param - Update: Script now reports raises an error when conflict in `exclude_children` between parent and child classes. - Bugfix: Trimmed whitespace programmatically from input exclusion file. - Bugfix: Trimmed whitespace manually in input exclusion file. - Comments/todo's: (i) added a todo for possible edge case issue w/ exclude_children - Update: Added param `--onto-name` to script. This is good for future proofing. Previously, I was extracting the ontology name from one of the file names that was passed as a param. However, as our pipeline changes, those file names are also subject to change. As such, it is more stable to pass the ontology name explicitly. - Update: Removed .owl -> .ttl hack, as now we have .owl files for ICD10CM and ICD10WHO / all ontologies.
- Add: ORDO exclusions - Update: refactor (i) comments, (ii) TODOs - Update: SPARQL: (i) removed the returning of term labels, (ii) utilized rdfs:label instead of skos:prefLabel, (iii) removed unnecessary prefixes. - Update: Used tmp/ dir for cache. Feature: ORDO Mapping annotations - Update: Use tmp/ dir for cache.
- Optionalized params: Now any path params will get populated using the required --onto-name param should they be absent. - CodeStyle: PEP8 compliance update - Script location: Simplified - Ontology config .yml updates: Added missing prefix_map items - Script now utilizes config.yml files for each ontology in order to filter out relevant prefixes. - doid_relevant_signature.sparql: added missing prefix - added warning for excluded terms that appear in relevant_signature file - Now includes non-inclusions, utilizing mirror_signature and component_signature.
- Added new command: 'python-install-dependencies' - Updated makefile commands to use new dependency 'python-install-dependencies' General - Some changes to makefile and a docs file related to running 'update_repo'
be60334
to
7574313
Compare
As of just now, I have went through and confirmed all open review threads have been resolved. I've now unmarked it as a draft. NCIT Java heap space issueThere is a new issue, but it is not related to the code in this PR. As @matentzn mentioned, I might need to increase my Java memory to resolve this issue:
What I tried: FYI for my future self: Can fix this via: |
7574313
to
8497809
Compare
4bae359
to
c3277db
Compare
- Update: TODOs - Update: Utilizing `base_prefix_map` now instead of `prefix_map` from ontology metadata `.yml` files. - Update: get-terms-children.sparql.jinja2: Always using rdfs:subClassOf* instead of a + at the end. Updated Python code to reflect. - Update: Makefile target: Now explicitly passes params again. - Added: New exclusion files: ORDO, DO. Still pending NCIT after resolving Java heap space issue. - Update: Robot template output: 'AI rdfs:seeAlso' --> 'AI MONDOREL:has_exclusion_reason'
c3277db
to
feb6514
Compare