Fix rendering association frequencies; use proper field for sorting them #911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for monarch-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This will have one failing test when running TypeScript checks, since |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #911 +/- ##
=======================================
Coverage 71.14% 71.14%
=======================================
Files 91 91
Lines 3136 3136
=======================================
Hits 2231 2231
Misses 905 905 ☔ View full report in Codecov by Sentry. |
kevinschaper
approved these changes
Nov 26, 2024
This was done to placate TypeScript. Since frequency_computed_sortable_float is not a type of Association, adding it as a key in the generic AssociationTable columns required changing a ton of code. It also doesn't make sense as a key, since that value is not returned in the record of an entity-- it's only an implicit sort key used by Solr.
kevinschaper
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Summary
frequency_qualifierChecks