-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update publications through 2024-10-02 #829
Conversation
✅ Deploy Preview for monarch-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #829 +/- ##
=======================================
Coverage 71.30% 71.30%
=======================================
Files 91 91
Lines 3136 3136
=======================================
Hits 2236 2236
Misses 900 900 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ptgolden, thanks for working on this. 🌟
There are a few updates that are needed with the year that some publications are landing. I have updated the Google Scholar publication dates for a handful of publications so it should now pull in and be correct.
For a consistency check when you to do the update, there should be a total of 19 publications in 2024 and 9 in 2023. This is because there are some 2023 preprints that were actually published in journals in 2024 and a few 2023 preprints with updates in 2024 so we need to move those around.
Please let me know when it is ready for a second review!
p.s. another consistency check will be that the graph at the top of the page matches the numbers we see on the google scholar page.
This duplicate should be removed now. Please let me know if you still see it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the requested changes have been done. The titles/headings are all appearing centered and the tiles are no longer stretched across the page. It looks like the 2024 publications are showing up correctly. I approve this version for release in October.
11 new publications from 2024, 1 from 2023.
There was an error with this publication where it did not have a year assigned in the Google Scholar metadata. I did an ad-hoc fix locally in the script; hopefully it will be updated by the next refresh.
Closes #828