Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update publications through 2024-10-02 #829

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

ptgolden
Copy link
Member

@ptgolden ptgolden commented Oct 2, 2024

11 new publications from 2024, 1 from 2023.

There was an error with this publication where it did not have a year assigned in the Google Scholar metadata. I did an ad-hoc fix locally in the script; hopefully it will be updated by the next refresh.

Closes #828

@ptgolden ptgolden requested a review from sagehrke October 2, 2024 15:43
Copy link

netlify bot commented Oct 2, 2024

Deploy Preview for monarch-app ready!

Name Link
🔨 Latest commit ce09506
🔍 Latest deploy log https://app.netlify.com/sites/monarch-app/deploys/6716d5aa6797430008d7e8ff
😎 Deploy Preview https://deploy-preview-829--monarch-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.30%. Comparing base (226062c) to head (ce09506).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #829   +/-   ##
=======================================
  Coverage   71.30%   71.30%           
=======================================
  Files          91       91           
  Lines        3136     3136           
=======================================
  Hits         2236     2236           
  Misses        900      900           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@sagehrke sagehrke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ptgolden, thanks for working on this. 🌟
There are a few updates that are needed with the year that some publications are landing. I have updated the Google Scholar publication dates for a handful of publications so it should now pull in and be correct.

For a consistency check when you to do the update, there should be a total of 19 publications in 2024 and 9 in 2023. This is because there are some 2023 preprints that were actually published in journals in 2024 and a few 2023 preprints with updates in 2024 so we need to move those around.

Please let me know when it is ready for a second review!

p.s. another consistency check will be that the graph at the top of the page matches the numbers we see on the google scholar page.

@ptgolden
Copy link
Member Author

ptgolden commented Oct 2, 2024

Any idea why there are duplicates here with different metadata?

image

@sagehrke
Copy link
Member

sagehrke commented Oct 2, 2024

This duplicate should be removed now. Please let me know if you still see it.

@amc-corey-cox
Copy link
Collaborator

@ptgolden and @sagehrke is this ready to go in? It looks like it could be merged as long as the requested changes are addressed. Let me know and we can get it merged for the October milestone.

Copy link
Member

@sagehrke sagehrke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the requested changes have been done. The titles/headings are all appearing centered and the tiles are no longer stretched across the page. It looks like the 2024 publications are showing up correctly. I approve this version for release in October.

@kevinschaper kevinschaper merged commit 793cd1c into main Oct 21, 2024
11 checks passed
@kevinschaper kevinschaper deleted the update-publications-oct-2024 branch October 21, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update https://monarchinitiative.org/publications with latest publication list from Google Scholar
4 participants