Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix api dying #353

Merged
merged 7 commits into from
Sep 29, 2023
Merged

Fix api dying #353

merged 7 commits into from
Sep 29, 2023

Conversation

glass-ships
Copy link
Collaborator

Adds a startup script to use in dockerfile instead of a list style CMD

@netlify
Copy link

netlify bot commented Sep 29, 2023 •
edited
Loading

✅ Deploy Preview for monarch-app canceled.

Name Link
🔨 Latest commit 2b5b5bf
🔍 Latest deploy log https://app.netlify.com/sites/monarch-app/deploys/651729ffa1775c0008514711

falquaddoomi
falquaddoomi approved these changes Sep 29, 2023
View reviewed changes
Copy link
Collaborator

@falquaddoomi falquaddoomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I made a small suggestion, but it's not critical for approval.

backend/start_api.sh Outdated Show resolved Hide resolved
@glass-ships @falquaddoomi
Update backend/start_api.sh
2b5b5bf 
Co-authored-by: Faisal Alquaddoomi <[email protected]>
@glass-ships glass-ships merged commit 3481eaf into main Sep 29, 2023
@glass-ships glass-ships deleted the fix-api-dying branch September 29, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@falquaddoomi falquaddoomi falquaddoomi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glass-ships @falquaddoomi