Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring in similarty through copy & paste instead of import #346

Merged
merged 3 commits into from
Sep 26, 2023

Conversation

kevinschaper
Copy link
Member

Initially this PR started off with just pulling the schema and seeing if we could minimally just move to using a Dict for now, but since the frontend was using the typescript interfaces for the similarity classes, I ended up just bringing the schema in minus the three conflicting slots...which is actually the most minimal change.

@netlify
Copy link

netlify bot commented Sep 25, 2023

Deploy Preview for monarch-app ready!

Name Link
🔨 Latest commit 9598f6b
🔍 Latest deploy log https://app.netlify.com/sites/monarch-app/deploys/651212ac16500300083e7596
😎 Deploy Preview https://deploy-preview-346--monarch-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kevinschaper kevinschaper merged commit 4af15c0 into main Sep 26, 2023
@kevinschaper kevinschaper deleted the issue-319-dont-import-oaklib-schema branch September 26, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants