-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feedback form - Chris Mungall - 1. One of the most important things a user wants to see o... #332
Comments
The biolink association in the url is just to remember what types of associations the user is currently viewing, it's not necessary for the page to load. It needs to be a stable, unique identifier for the type of association, so if someone can tell me a shorter/abbreviated string that meets that criteria, I can put it in. |
Is there only ever one causal gene? If so, that could be included in the top level of the node api response, and I could display it in the "Overview" or "Details" section. I could also auto-select the casual-gene associations in the associations section when it's a particular type of node. But I don't think it would be a good idea to conditionally move the associations section up to the top, if that's part of your suggestion; best to keep things in a consistent order. |
for a disease entity you can assume a distrubution that is mostly zero or one, sometimes 2, rarely 3 etc but for grouping classes obviously more - but still relevant to show these up top. E.g for MPS a user would expected the causal genes to be shown prominently |
Related, |
Suggestion per @kevinschaper , when first loading node page, and auto-selecting first association type, don't put that in url. Wait for user to explicitly change association type to put in url. |
Closes #332 - remove /node url path prefix for node page - add casual gene top level field, display on node page overview section - tweak click-to-copy id buttons - refactor link component to make more flexible - use node badge component in pheno explorer results - dont put associations category in url until user explicitly changes the selected category - move taxon up one section to make more prominent - don't show hierarchy section for genes
I'm not sure the solution (although it is an improvement) addresses the issue that the actual disease association is quite hidden? It still isn't clear why you would want to put "hierarchy" or "details" above "associations" (anywhere). I guess heirarchy is above annotations because you want to focus on the "knowledge graph" aspect of Monarch . But how key is this to most of the end users of the website? "Details" is a slightly random collection (source, taxon, external references), but it's also odd that "taxon" ( a key piece of information) isn't in the overview. |
@ValWood Make sure you are looking at Taxon was moved to the overview section. Regarding your other comment, it sounds like you're proposing the order should be: Overview, Associations, Hierarchy, Breadcrumbs, Details. It's very easy to change the order of these sections. I just don't want them to be in different orders on different nodes. Another thing is that other members of the team signed off on this order in the design. If @putmantime or someone wants to give me the go ahead, I'd be happy to change the order. |
Yes the ordering was only an observation- definitely something you should check with UX rather than a single feedback. |
Name
Chris Mungall
Email
[email protected]
GitHub Username
cmungall
Details
Page: /node/MONDO:0011675?associations=biolink:DiseaseToPhenotypicFeatureAssociation
Browser: Chrome 116.0.0.0
Device: Apple Macintosh
OS: Mac OS 10.15.7
Engine: Blink 116.0.0.0
The text was updated successfully, but these errors were encountered: