6.4.6 #1288
Merged
6.4.6 #1288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
commented
Nov 9, 2024
•
github-actions
bot
commented
- Fix regression when connecting solely using old STARTTLS connection method
- Fix crash when being unable to connect while creating new account
- Fix connection problems on slow connections
- Show timestamp of last received push in notification debug menu
- Fix various other crashes
Calling the invalidate method from some other thread than the thread which added the timer to our runloop, will crash. --> Add and remove the timer to/from the runloop by executing a block in exactly this runloop.
- Fix various crashes - Fix connection problems on slow connections - Show timestamp of last received push in notification debug menu
Calling the invalidate method from some other thread than the thread which added the timer to our runloop, will crash. --> Add and remove the timer to/from the runloop by executing a block in exactly this runloop.
Reverts #1287
- Fix various crashes - Fix connection problems on slow connections - Show timestamp of last received push in notification debug menu
When creating a new account that can not be connected to, a timeout error is triggered after 30 seconds. If the app was put into background, a disconnect and receiveQueue freeze could happen before the timeout handler tries to disconnect again. Prviosuly this triggered an assertion, now we try to handle that case more gracefully while not introducing new race conditions.
- Fix regression when connecting solely using old STARTTLS connection method - Fix crash when being unable to connect while creating new account
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.