6.3.1b1 #1057
Merged
6.3.1b1 #1057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tmolitor-stud-tu
commented
May 2, 2024
tmolitor-stud-tu
commented
- Fix flickering of chat background image
- Make keyboard auto-appear configurable
- Improve error propagation when uploading/downloading files
- Fix detection of omemo keys for groupchats
- Make several UI elements translatable now
- Fix error handling when creating groups
- Show used / discovered MUC servers in server details
6.3.0b5
This won't extract all strings, since setting SWIFT_EMIT_LOC_STRINGS=YES which would extract all strings as opposed to only `Text()` strings makes xcode compile the whole project for extraction which fails with the WebRTC lib not being found.
Without setting SWIFT_EMIT_LOC_STRINGS=YES, only Text() views are translatable. But we can't set SWIFT_EMIT_LOC_STRINGS=YES, because this tries to compile the whole project and always fails when importing the WebRTC lib. Switching from cocoapods to SPM for the WebRTC lib makes the project compile (even for extracting localizable strings), but crash early when starting the app (even before main.m is reached). This seems to be a dylib loading issue.
For details, see previous commit making Toggle() translatable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.