elasticsearchを動くようにした #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
momocus
force-pushed
the
fix-elastic
branch
2 times, most recently
from
72f39df to
482604d
Compare
|
elasticsearch-railsが正式にruby3対応したら、 ただちに正式版を適用して 24e3117 をrevertする必要がある。 |
yonta
reviewed
Jul 5, 2021
Co-authored-by: SAITOU Keita <[email protected]>
yonta
reviewed
Jul 7, 2021
| local: true, | ||
| class: "row my-1",) do |f| %> | ||
| <div class="col-auto"> | ||
| <%= f.label(:word, { class: "form-label visually-hidden" }) %> |
yonta
approved these changes
Jul 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#224 が動かなかったので修正した
e3d62a8
bootstrap5化によるviewの変更を忘れていたので対応した。
24e3117
elasticsearch-railsが現状ruby3対応しておらず、DBのデータをelasticsearch側にimportするときにエラーが起こる。修正のプルリクは出ていたがreleaseがいつになるかは不明。elastic/elasticsearch-rails#989 (comment) で、せっかちな人はこうしてねと書かれていた方法に従った。
githubのリポジトリを指定しgemをダウンロードするため、docker環境にもgitをインストールした。