Skip to content
This repository has been archived by the owner on Aug 3, 2020. It is now read-only.

Wrong version used for browser bundle, the previous version is used #36

Closed
momocow opened this issue Oct 23, 2018 · 4 comments
Closed

Comments

@momocow
Copy link
Owner

momocow commented Oct 23, 2018

That is because the browser bundle is built before semantic-release which actually bumps the version.

Also need to configure not to bundle irrelevant version of browser files from the dist/ directory to NPM release.

@momocow momocow added the bug label Oct 23, 2018
@satouriko
Copy link
Contributor

satouriko commented Oct 23, 2018 via email

@satouriko
Copy link
Contributor

satouriko commented Oct 23, 2018 via email

@momocow
Copy link
Owner Author

momocow commented Oct 23, 2018

CDN 可以指定 NPM Release 的版本的

好欸, 原來如此 🎉

inazuma-bot added a commit that referenced this issue Oct 24, 2018
## [1.8.1](v1.8.0...v1.8.1) (2018-10-24)

### Bug Fixes

* do not include version in filename of browser bundle ([374f378](374f378)), closes [#36](#36)
@inazuma-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 1.8.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants