Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More map selector related changes #1052

Closed
wants to merge 2 commits into from
Closed

Conversation

tsa96
Copy link
Member

@tsa96 tsa96 commented Oct 18, 2024

  • Adds simple header to the static map lists (4 byte: ident, 4 byte: length of uncompressed length, 4 byte: total number of maps). Makes decompressing in game code a lot nicer.

Checks

  • !! DONT IGNORE ME !! I have ran nx run db:create-migration <name> and committed the migration if I've made DB schema changes
  • I have included/updated tests where applicable (see Testing)
  • I have followed semantic commit messages e.g. feat: Add foo, chore: Update bar, etc...
  • My branch has a clear history of changes that can be easy to follow when being reviewed commit-by-commit
  • My branch is functionally complete; the only changes to be done will be those potentially requested in code review
  • All changes requested in review have been fixuped into my original commits

@tsa96 tsa96 force-pushed the refactor/more-map-selector branch 2 times, most recently from 6aab317 to 605c36d Compare October 19, 2024 09:58
@tsa96
Copy link
Member Author

tsa96 commented Nov 17, 2024

Oops, #1064 superseded this.

@tsa96 tsa96 closed this Nov 17, 2024
@tsa96 tsa96 deleted the refactor/more-map-selector branch November 17, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant