Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make maps/submissions GET max take param unlimited for reviewers/mods/admins #1071

Closed
tsa96 opened this issue Nov 16, 2024 · 0 comments · Fixed by #1073
Closed

Make maps/submissions GET max take param unlimited for reviewers/mods/admins #1071

tsa96 opened this issue Nov 16, 2024 · 0 comments · Fixed by #1073
Assignees
@tsa96
Labels
For: Backend This is something to do for the backend (server folder) of the website. Priority: High Should be done first and foremost, absolutely essential for this release. Size: Small Something that may take a day at most to do.

Comments

@tsa96
Copy link
Member

tsa96 commented Nov 16, 2024

Map selector doesn't do pagination, may have over 100 maps visible to reviewers, mods and admins that are in Content Approval.

For them, set take to unlimited, if they don't provide a take param (the game HTTP code won't, for anyone) don't set a take value on the DB query. For other users, limit it to 100.
@tsa96 tsa96 added Size: Small Something that may take a day at most to do. Priority: High Should be done first and foremost, absolutely essential for this release. For: Backend This is something to do for the backend (server folder) of the website. labels Nov 16, 2024
@tsa96 tsa96 self-assigned this Nov 16, 2024
tsa96 added a commit that referenced this issue Nov 18, 2024
@tsa96
feat(back): allow reviewers to request unlimited maps in submission
800e0cc 
Closes #1071
@tsa96 tsa96 mentioned this issue Nov 18, 2024
Merged
6 tasks
tsa96 added a commit that referenced this issue Nov 18, 2024
@tsa96
feat(back): allow reviewers to request unlimited maps in submission
2669a52 
Closes #1071
tsa96 added a commit that referenced this issue Nov 19, 2024
@tsa96
feat(back): allow reviewers to request unlimited maps in submission
22cc545 
Closes #1071
@tsa96 tsa96 closed this as completed in b2a832a Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsa96 tsa96

Labels
For: Backend This is something to do for the backend (server folder) of the website. Priority: High Should be done first and foremost, absolutely essential for this release. Size: Small Something that may take a day at most to do.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat/map submission misc 2 momentum-mod/website
1 participant
@tsa96