Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

console/autocomplete style tweaks #95

Merged
merged 1 commit into from
Aug 10, 2023
Merged

console/autocomplete style tweaks #95

merged 1 commit into from
Aug 10, 2023

Conversation

jason-e
Copy link
Member

@jason-e jason-e commented Aug 10, 2023

  • Offset initial console position from corner
  • Remove autocomplete selection transitions to make nav snappier
  • Fix autocomplete mouse hover color priority
  • Make autocomplete shadow not obscure entry box
  • Make autocomplete a bit taller

Checks

  • I have thoroughly tested all of the code I have modified/added/removed to ensure something else did not break
  • I have followed semantic commit messages e.g. feat: Add foo, chore: Update bar, etc...
  • My branch has a clear history of changes that can be easy to follow when being reviewed commit-by-commit
  • My branch is functionally complete; the only changes to be done will be those potentially requested in code review
  • All changes requested in review have been fixuped into my original commits.
  • Fully tokenized all my strings (no hardcoded English strings!!) and supplied bulk JSON strings below

@jason-e
feat: console style tweaks
f462e98 
- Offset initial console position from corner
- Remove autocomplete selection transitions to make nav snappier
- Fix autocomplete mouse hover color priority
- Make autocomplete shadow not obscure entry box
- Make autocomplete a bit taller
@tsa96 tsa96 merged commit 687bc46 into master Aug 10, 2023
1 check passed
@tsa96 tsa96 deleted the feat/console-style-tweaks branch August 10, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsa96 tsa96 tsa96 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jason-e @tsa96