fix: refactor compass ticks #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsa96
approved these changes
Sep 16, 2023
PeenScreeker
force-pushed
the
fix/compass
branch
2 times, most recently
from
907bdb1
to
dfb7647
Compare
|
Still lgtm |
Gocnak
approved these changes
Sep 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes momentum-mod/game/issues/2100
This pull request changes the behavior of the compass HUD element to match the most recent version of the defrag pitch helper.
Previously, compass ticks were created as left and right borders of a panel. Now ticks are individual panels with fixed width. This prevents border properties from misbehaving when the color is changed.
Checks
feat: Add foo,chore: Update bar, etc...fixuped into my original commits.