chore: upgrade Momento sdk dependencies in demos #80
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -38,6 +38,7 @@ | |||
| ignoresPersistentStateOnLaunch = "NO" | |||
| debugDocumentVersioning = "YES" | |||
| debugServiceExtension = "internal" | |||
| enableGPUValidationMode = "1" | |||
| @@ -1,5 +1,5 @@ | |||
| // Top-level build file where you can add configuration options common to all sub-projects/modules. | |||
| plugins { | |||
| id("com.android.application") version "8.2.2" apply false | |||
| id("com.android.application") version "8.7.2" apply false | |||
There was a problem hiding this comment.
When I tried running this in my copy of Android Studio, it prompted me to upgrade to Gradle 8.9. After I clicked the link to upgrade, I got the following error: The project is using an incompatible version (AGP 8.7.2) of the Android Gradle plugin. Latest supported version is AGP 8.2.2 Apparently only the very latest version of Android Studio has support for AGP 8.7, and the app builds and functions fine with the versions we were previously using. Unless you had a compelling reason to update this (and the distributionUrl in the gradle-wrapper.properties) I think we should keep them as they were.
There was a problem hiding this comment.
Okay good to know, will change it back. I think these changed as a result of me clicking "yes" to a recommended update from Android Studio
| ``` | ||
|
|
||
| Note: if you run into an error saying "principal class is nil because all fallbacks have failed", you can try turning off API validation in the settings as mentioned in this [github issue comment](https://github.com/flutter/flutter/issues/150227#issuecomment-2423291527). |
There was a problem hiding this comment.
@nand4011 the enableGPUValidationMode = "1" line was to handle this issue I ran into based on this comment. Without this, the app failed to build or run.
I ran it again this morning with this setting both on and off and it was fine though.
Would be good to get a second person to try the Swift demo and verify if the setting is actually needed
Closes https://github.com/momentohq/dev-eco-issue-tracker/issues/1067
We recently added support for topics sequence page in our SDKs. We upgraded the Momento dependency for the main moderated chat web demo in #77.
This PR upgrades the Momento dependency in the remaining demos (react-native, android, ios, flutter).
Edit: bug fix was released in JS sdk so the react-native and web demo Momento dependencies were updated too.
Extra cleanup: