Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cloudwatch metrics example #970

Merged
merged 33 commits into from
Nov 6, 2023
Merged

Conversation

anitarua
Copy link
Contributor

@anitarua anitarua commented Oct 17, 2023

Addresses #442. Created a new lambda-examples directory to show how a CDK stack can be configured to deploy a Lambda function or ECS cluster, create metric filters for the associated log groups (or a custom log group), and create a CloudWatch dashboard.

The dashboard looks something like this when populated (updated dashboard):
cloudwatch dashboard

The dashboard uses values in the logs emitted by both the Nodejs SDK metrics and .NET SDK metrics interfaces.

Also tested that this works with a .NET lambda function (that work currently exists in an unmerged branch but can merge into the dotnet repo if it seems useful).

Let me know if you think the dashboard should include/exclude any other metrics!

Original dashboard when PR opened:
metrics example dashboard

@anitarua anitarua marked this pull request as ready for review October 17, 2023 23:44
Copy link
Contributor

@cprice404 cprice404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is looking awesome!

i want to test it in my account before we merge it, and not sure if i will get to that today. but i left a handful of minor feedback that I think you could go ahead and move forward on when you have bandwidth.

@anitarua anitarua requested a review from cprice404 October 19, 2023 20:53
Copy link
Contributor

@cprice404 cprice404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

anita i deployed this locally and started playing with it, but ran out of time. I will finish reviewing this evening!

Copy link
Contributor

@cprice404 cprice404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is looking really awesome. I left some comments for us to fine tune the dashboard widgets in this last mile, to make them more realistic for an operator dashboard, but this is really great and I can see the finish line!

@anitarua
Copy link
Contributor Author

anitarua commented Nov 1, 2023

Lots of great feedback, thanks!! Here's what the dashboard looks like now

cloudwatch dashboard

@anitarua anitarua requested a review from cprice404 November 6, 2023 18:52
Copy link
Contributor

@cprice404 cprice404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dance

@anitarua anitarua merged commit e72f69f into main Nov 6, 2023
13 checks passed
@anitarua anitarua deleted the cloudwatch-metrics-example branch November 6, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants