-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: cloudwatch metrics example #970
Conversation
examples/nodejs/lambda-examples/cloudwatch-metrics/infrastructure/lib/momento-metrics-stack.ts
Outdated
Show resolved
Hide resolved
examples/nodejs/lambda-examples/cloudwatch-metrics/infrastructure/lib/momento-metrics-stack.ts
Outdated
Show resolved
Hide resolved
examples/nodejs/lambda-examples/cloudwatch-metrics/infrastructure/lib/momento-metrics-stack.ts
Outdated
Show resolved
Hide resolved
examples/nodejs/lambda-examples/cloudwatch-metrics/lambda/handler.ts
Outdated
Show resolved
Hide resolved
examples/nodejs/lambda-examples/cloudwatch-metrics/lambda/handler.ts
Outdated
Show resolved
Hide resolved
examples/nodejs/lambda-examples/cloudwatch-metrics/infrastructure/bin/infrastructure.ts
Show resolved
Hide resolved
examples/nodejs/lambda-examples/cloudwatch-metrics/infrastructure/lib/momento-metrics-stack.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is looking awesome!
i want to test it in my account before we merge it, and not sure if i will get to that today. but i left a handful of minor feedback that I think you could go ahead and move forward on when you have bandwidth.
examples/nodejs/lambda-examples/cloudwatch-metrics/docker/ecs-code/index.ts
Outdated
Show resolved
Hide resolved
examples/nodejs/lambda-examples/cloudwatch-metrics/docker/Dockerfile
Outdated
Show resolved
Hide resolved
examples/nodejs/lambda-examples/cloudwatch-metrics/infrastructure/lib/momento-metrics-stack.ts
Show resolved
Hide resolved
examples/nodejs/lambda-examples/cloudwatch-metrics/infrastructure/lib/momento-metrics-stack.ts
Outdated
Show resolved
Hide resolved
examples/nodejs/lambda-examples/cloudwatch-metrics/infrastructure/lib/momento-metrics-stack.ts
Outdated
Show resolved
Hide resolved
examples/nodejs/lambda-examples/cloudwatch-metrics/infrastructure/lib/momento-metrics-stack.ts
Outdated
Show resolved
Hide resolved
examples/nodejs/lambda-examples/cloudwatch-metrics/lambda/handler.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
anita i deployed this locally and started playing with it, but ran out of time. I will finish reviewing this evening!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is looking really awesome. I left some comments for us to fine tune the dashboard widgets in this last mile, to make them more realistic for an operator dashboard, but this is really great and I can see the finish line!
examples/nodejs/lambda-examples/cloudwatch-metrics/infrastructure/lib/momento-metrics-stack.ts
Outdated
Show resolved
Hide resolved
examples/nodejs/lambda-examples/cloudwatch-metrics/docker/Dockerfile
Outdated
Show resolved
Hide resolved
examples/nodejs/lambda-examples/cloudwatch-metrics/infrastructure/lib/momento-metrics-stack.ts
Outdated
Show resolved
Hide resolved
examples/nodejs/lambda-examples/cloudwatch-metrics/infrastructure/lib/momento-metrics-stack.ts
Outdated
Show resolved
Hide resolved
examples/nodejs/lambda-examples/cloudwatch-metrics/infrastructure/lib/momento-metrics-stack.ts
Outdated
Show resolved
Hide resolved
examples/nodejs/lambda-examples/cloudwatch-metrics/infrastructure/lib/momento-metrics-stack.ts
Outdated
Show resolved
Hide resolved
examples/nodejs/lambda-examples/cloudwatch-metrics/infrastructure/lib/momento-metrics-stack.ts
Outdated
Show resolved
Hide resolved
examples/nodejs/lambda-examples/cloudwatch-metrics/infrastructure/lib/momento-metrics-stack.ts
Show resolved
Hide resolved
…per second graph axis, update readme
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addresses #442. Created a new
lambda-examples
directory to show how a CDK stack can be configured to deploy a Lambda function or ECS cluster, create metric filters for the associated log groups (or a custom log group), and create a CloudWatch dashboard.The dashboard looks something like this when populated (updated dashboard):
The dashboard uses values in the logs emitted by both the Nodejs SDK metrics and .NET SDK metrics interfaces.
Also tested that this works with a .NET lambda function (that work currently exists in an unmerged branch but can merge into the dotnet repo if it seems useful).
Let me know if you think the dashboard should include/exclude any other metrics!
Original dashboard when PR opened: