Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for deleting keys #68

Merged
merged 4 commits into from
May 3, 2022
Merged

feat: add support for deleting keys #68

merged 4 commits into from
May 3, 2022

Conversation

bruuuuuuuce
Copy link
Contributor

@bruuuuuuuce bruuuuuuuce commented Apr 26, 2022 •
edited
Loading

This should not get merged until https://github.com/momentohq/cacheservice/pull/654 gets merged and deployed

poppoerika
poppoerika previously approved these changes Apr 27, 2022
View reviewed changes
Copy link
Contributor

@poppoerika poppoerika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
As you mentioned, we want to wait for merging this until the cacheservice pr to get merged and also the newly added test to pass 👍

@bruuuuuuuce bruuuuuuuce requested a review from poppoerika April 30, 2022 03:59
@bruuuuuuuce bruuuuuuuce merged commit 4cab010 into main May 3, 2022
@bruuuuuuuce bruuuuuuuce deleted the feat/deleteApi branch May 3, 2022 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poppoerika poppoerika poppoerika approved these changes

@tylerburdsall tylerburdsall tylerburdsall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bruuuuuuuce @tylerburdsall @poppoerika