Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement sorted set fetch by score #320

Merged
merged 5 commits into from
Mar 6, 2023

Conversation

malandis
Copy link
Contributor

@malandis malandis commented Mar 3, 2023

Implements sortedSetFetchByScore. A future PR will implement the other features of this API, including min/max inclusive vs exclusive flags, limit, and count; as well as testing.

@malandis malandis requested a review from cprice404 March 3, 2023 23:02
@malandis malandis marked this pull request as ready for review March 3, 2023 23:07
@cprice404
Copy link
Contributor

Implements sortedSetFetchByScore. A future PR will implement the other features of this API, including min/max inclusive vs exclusive flags, limit, and count; as well as testing.

we decided not to expose those inclusive/exclusive flags unless we get a request.

Copy link
Contributor

@cprice404 cprice404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! thanks

@malandis malandis merged commit a080732 into main Mar 6, 2023
@malandis malandis deleted the feat/sorted-set-fetch-by-score branch March 6, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants