Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check for undefined userAgent string before calling includes() #1473

Merged
merged 1 commit into from
Dec 2, 2024
Merged

fix: check for undefined userAgent string before calling includes() #1473

merged 1 commit into from
Dec 2, 2024

Conversation

pgautier404
Copy link
Contributor

This commit prevents a potential fatal runtime error caused by calling includes() on a variable whose value is undefined.

@pgautier404 pgautier404 requested a review from anitarua December 2, 2024 19:29
@pgautier404 pgautier404 merged commit a12be86 into main Dec 2, 2024
13 checks passed
@pgautier404 pgautier404 deleted the check-undefined-user-agent branch December 2, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anitarua anitarua anitarua approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pgautier404 @anitarua