Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use unique topic names in tests #1458

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Conversation

anitarua
Copy link
Contributor

@anitarua anitarua commented Oct 28, 2024

While investigating some canary failures, discovered that some auth topics tests were reusing topic names.
Added a new util function to ensure unique topic names are used in all topics tests.

@anitarua anitarua marked this pull request as ready for review October 28, 2024 22:55
@anitarua anitarua requested a review from a team October 28, 2024 22:55
Copy link
Contributor

@kvcache kvcache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems legit to me

Copy link
Contributor

@rishtigupta rishtigupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@anitarua anitarua merged commit 017af64 into main Oct 28, 2024
13 checks passed
@anitarua anitarua deleted the unique-test-topic-names branch October 28, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants