Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update examples to instantiate clients with only default configs #1443

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

anitarua
Copy link
Contributor

@anitarua anitarua commented Oct 7, 2024

Closes https://github.com/momentohq/dev-eco-issue-tracker/issues/1035

Removes empty config objects from client instantiations that use only default configs now that the client props are optional.

@anitarua anitarua marked this pull request as ready for review October 7, 2024 19:58
@anitarua anitarua requested a review from a team October 7, 2024 19:59
@anitarua anitarua merged commit 3231de6 into main Oct 7, 2024
13 checks passed
@anitarua anitarua deleted the examples-optional-client-props branch October 7, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants