chore: make sure storage tests use unique stores #1433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cprice404
reviewed
Sep 5, 2024
anitarua
commented
Sep 5, 2024
Comment on lines
+260
to
+266
| beforeAll(async () => { | ||
| await createStoreIfNotExists(storageClient, integrationTestStoreName); | ||
| }); | ||
|
|
||
| afterAll(async () => { | ||
| await deleteStoreIfExists(storageClient, integrationTestStoreName); | ||
| }); |
There was a problem hiding this comment.
added a beforeAll and afterAll to create a shared store that can be used by storage data plane tests. this will prevent leaked stores and ensure minimal creation of stores where possible.
anitarua
commented
Sep 5, 2024
| switch (putBytesResponse.type) { | ||
| case StoragePutResponse.Success: { | ||
| // WithStore creates a store then deletes it | ||
| await WithStore(storageClient, storeName, async () => { |
There was a problem hiding this comment.
used WithStore in this test to make it more concise, but it does the same thing as before (calls create, create, delete)
anitarua
commented
Sep 5, 2024
| }, `expected NotFound, received ${getResponse.toString()}`); | ||
| expect(getResponse.value()).toBeUndefined(); | ||
| }); | ||
| }); | ||
| it('should return store not found error for deleting a store that doesnt exist', async () => { |
There was a problem hiding this comment.
moved 'should return store not found error for deleting a store that doesnt exist' to the storage control plane block of tests
anitarua
commented
Sep 5, 2024
| await sleep(5000); | ||
| // Data plane tests should use the shared integration test store | ||
| // with the BeforeAll setup and AfterAll teardown | ||
| describe('#store get put and delete', () => { |
There was a problem hiding this comment.
all the storage data plane tests should be in this describe block and should use the shared store with unique keys
cprice404
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should use the
WithStorehelper function to create a unique store for each storage control plane test.Creates single shared store for storage data plane tests using a
beforeAlland is cleaned up using anafterAll.Remove the "should successfully make two of the same requests after 5s retry timeout" test, which I added to test an edge case while developing the storage retry strategy, but it is no longer relevant after collapsing the fixed timeout interceptor into the retry interceptor.