fix: improve TopicClient connection resiliency #1400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cprice404
force-pushed
the
experimenting-with-topic-reconnection
branch
from
f89046f to
9bdbcb1
Compare
anitarua
reviewed
Aug 9, 2024
| @@ -32,6 +32,11 @@ export class Default extends TopicClientConfiguration { | |||
| transportStrategy: new StaticTopicTransportStrategy({ | |||
| grpcConfiguration: new StaticTopicGrpcConfiguration({ | |||
| numClients: 1, | |||
| // TODO: when we introduce lambda configurations, we do not want to enable keepalives, because they | |||
There was a problem hiding this comment.
would it be worth it to just add the lambda config now?
Comment on lines
192
to
193
| // restartedDueToError: false, | ||
| // firstMessage: true, |
At some point in time a refactor seems to have made the TopicClient less resilient to network interruptions. It may have happened when we made changes to disable keepalives by default (due to lambda issues), or during some refactor work to add topics support to the web SDK. This commit does the following: * Add configuration options for grpc keepalives and enable them in the default topicclient config * Adds a good deal of trace-level logging to help debug what is happening when subscriptions are interrupted * Re-work the error-handling and "end of stream" logic a bit to improve connection resiliency. I tested this on my laptop by disabling my wifi after the subscription was created. Prior to these changes, the network issues were not detected and the connection was left in a broken state. After these changes, the issues are detected and the connection is re-established successfully.
cprice404
force-pushed
the
experimenting-with-topic-reconnection2
branch
from
a013d8a to
6d2907a
Compare
malandis
reviewed
Aug 12, 2024
anitarua
approved these changes
Aug 12, 2024
malandis
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At some point in time a refactor seems to have made the TopicClient less resilient to network interruptions. It may have happened when we made changes to disable keepalives by default (due to lambda issues), or during some refactor work to add topics support to the web SDK.
This commit does the following:
I tested this on my laptop by disabling my wifi after the subscription was created. Prior to these changes, the network issues were not detected and the connection was left in a broken state. After these changes, the issues are detected and the connection is re-established successfully.