Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add SetPop and SetLength #1397

Merged
merged 3 commits into from
Aug 8, 2024
Merged

feat: add SetPop and SetLength #1397

merged 3 commits into from
Aug 8, 2024

Conversation

anitarua
Copy link
Contributor

@anitarua anitarua commented Aug 1, 2024

Adds missing set methods to node and web SDKs

@anitarua anitarua marked this pull request as ready for review August 1, 2024 16:51
@anitarua anitarua requested a review from a team August 8, 2024 20:03
Copy link
Contributor

@malandis malandis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I have a few clarifying comments

packages/common-integration-tests/src/set.ts Outdated Show resolved Hide resolved
packages/common-integration-tests/src/set.ts Outdated Show resolved Hide resolved
packages/common-integration-tests/src/set.ts Outdated Show resolved Hide resolved
@anitarua anitarua requested a review from malandis August 8, 2024 23:17
@anitarua anitarua merged commit 2028da3 into main Aug 8, 2024
13 checks passed
@anitarua anitarua deleted the set-length-pop branch August 8, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants