Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: nodejs first-time headers should be sent per client #1387

Merged
merged 1 commit into from
Jul 9, 2024
Merged

fix: nodejs first-time headers should be sent per client #1387

merged 1 commit into from
Jul 9, 2024

Conversation

anitarua
Copy link
Contributor

@anitarua anitarua commented Jul 9, 2024 •
edited
Loading

Each client creates an instance of class HeaderInterceptorProvider which is responsible for determining whether to send the first-request headers.

To ensure each client sends them on their first request, I switched the areOnlyOnceHeadersSent from a static variable to a non-static one.

@anitarua anitarua marked this pull request as ready for review July 9, 2024 20:44
@anitarua anitarua requested a review from a team July 9, 2024 20:44
bruuuuuuuce
bruuuuuuuce approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@bruuuuuuuce bruuuuuuuce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: nice find!

@anitarua anitarua merged commit 622acf2 into main Jul 9, 2024
13 checks passed
@anitarua anitarua deleted the fix-headers branch July 9, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruuuuuuuce bruuuuuuuce bruuuuuuuce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anitarua @bruuuuuuuce