Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add cacheclient.create function in web sdk #1386

Merged
merged 4 commits into from
Jul 16, 2024
Merged

feat: add cacheclient.create function in web sdk #1386

merged 4 commits into from
Jul 16, 2024

Conversation

rishtigupta
Copy link
Contributor

@rishtigupta rishtigupta commented Jul 9, 2024 •
edited
Loading

@rishtigupta rishtigupta force-pushed the feat/cache-client-create branch from c826235 to 3ee4cfc Compare July 9, 2024 18:23
@rishtigupta rishtigupta marked this pull request as ready for review July 9, 2024 18:50
@rishtigupta rishtigupta requested review from cprice404 and a team July 9, 2024 18:50
cprice404
cprice404 reviewed Jul 9, 2024
View reviewed changes
Copy link
Contributor

@cprice404 cprice404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor change, thanks for doing this

packages/client-sdk-web/src/cache-client.ts Outdated Show resolved Hide resolved
@rishtigupta rishtigupta requested a review from cprice404 July 15, 2024 16:57
@rishtigupta rishtigupta merged commit 1ee7a36 into main Jul 16, 2024
13 checks passed
@rishtigupta rishtigupta deleted the feat/cache-client-create branch July 16, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cprice404 cprice404 cprice404 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rishtigupta @cprice404