feat: Switch default compression to gzip #1267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we have the @gomomento/sdk-nodejs-compression-zstd package, this commit updates the default compression extensions package to use gzip as the compression algorithm rather than zstd. This allows us to get rid of the binary dependency that makes packaging complicated. We made the decision to do this after benchmarking showed very little difference in compression ratio and only a little difference in performance between the two compression libraries; therefore, shedding the packaging complexity for a simpler user experience seemed like the best UX choice.
malandis
approved these changes
May 7, 2024
Comment on lines
-54
to
+55
| 40, 181, 47, 253, 0, 96, 65, 0, 0, 109, 121, 45, 118, 97, 108, 117, 101, | ||
| 31, 139, 8, 0, 0, 0, 0, 0, 2, 19, 203, 173, 212, 45, 75, 204, 41, 77, 5, 0, | ||
| 58, 70, 91, 55, 8, 0, 0, 0, |
| "@gomomento/sdk": "file:../client-sdk-nodejs", | ||
| "@mongodb-js/zstd": "1.2.0" | ||
| "@gomomento/sdk": "file:../client-sdk-nodejs" |
There was a problem hiding this comment.
Since zlib is part of the node runtime, does this package need to be an external dependency then? Couldn't it be included with the nodejs client?
There was a problem hiding this comment.
we talked about this in the team meeting the other day. for now i'd prefer that users need to stop and consider options, so i like it being separate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have the @gomomento/sdk-nodejs-compression-zstd package,
this commit updates the default compression extensions package
to use gzip as the compression algorithm rather than zstd. This
allows us to get rid of the binary dependency that makes packaging
complicated. We made the decision to do this after benchmarking
showed very little difference in compression ratio and only a little
difference in performance between the two compression libraries;
therefore, shedding the packaging complexity for a simpler user
experience seemed like the best UX choice.