feat: more webhook int test (#1037)

momentohq · Nov 14, 2023 · fe2bb8c · fe2bb8c
1 parent ff573ae
commit fe2bb8c
Show file tree

Hide file tree

Showing 2 changed files with 52 additions and 8 deletions.
diff --git a/packages/common-integration-tests/src/common-int-test-utils.ts b/packages/common-integration-tests/src/common-int-test-utils.ts
@@ -35,12 +35,15 @@ export function testIndexName(): string {
 
 export function testWebhook(cache?: string): Webhook {
   const cacheName = cache ?? testCacheName();
+  const webhookName = `webhook-${cacheName}`;
   return {
     id: {
       cacheName,
-      webhookName: `webhook-${cacheName}`,
+      webhookName,
     },
-    destination: new PostUrlWebhookDestination('https://www.fake.url.com'),
+    destination: new PostUrlWebhookDestination(
+      `https://synthetics-webhooks.synthetics.preprod.a.momentohq.com/v1/webhooks/${webhookName}`
+    ),
     topicName: `topic-${v4()}`,
   };
 }
@@ -393,3 +396,18 @@ export function expectWithMessage(expected: () => void, message: string) {
     throw new Error(message);
   }
 }
+
+type WebhookRequestDetails = {
+  invocationCount: number;
+  requestId: string;
+};
+export async function getWebhookRequestDetails(
+  webhookDestination: string
+): Promise<WebhookRequestDetails> {
+  const resp = await fetch(webhookDestination);
+
+  if (!resp.ok) {
+    throw new Error(`failed to get webhook details: ${await resp.text()}`);
+  }
+  return (await resp.json()) as WebhookRequestDetails;
+}
diff --git a/packages/common-integration-tests/src/webhooks.ts b/packages/common-integration-tests/src/webhooks.ts
@@ -2,8 +2,10 @@ import {
   PostUrlWebhookDestination,
   ListWebhooks,
   GetWebhookSecret,
+  TopicPublish,
 } from '@gomomento/sdk-core';
 import {
+  getWebhookRequestDetails,
   ItBehavesLikeItValidatesCacheName,
   ItBehavesLikeItValidatesTopicName,
   testWebhook,
@@ -15,6 +17,7 @@ import {
   ICacheClient,
   ITopicClient,
 } from '@gomomento/sdk-core/dist/src/internal/clients';
+import {delay} from './auth-client';
 
 export function runWebhookTests(
   topicClient: ITopicClient,
@@ -77,11 +80,11 @@ export function runWebhookTests(
                 wh.id.cacheName === webhook.id.cacheName
             );
           expect(webhookWeAreLookingFor).toBeTruthy();
+        } else if (resp instanceof ListWebhooks.Error) {
+          throw new Error(`list webhooks request failed: ${resp.message()}`);
         } else {
           throw new Error(
-            `list webhooks request failed: ${(
-              resp as ListWebhooks.Error
-            ).message()}`
+            `unknown error occured when making a 'listWebhooks' request: ${resp.toString()}`
           );
         }
       });
@@ -97,14 +100,37 @@ export function runWebhookTests(
           expect(resp.secret()).toBeTruthy();
           expect(resp.webhookName()).toEqual(webhook.id.webhookName);
           expect(resp.cacheName()).toEqual(webhook.id.cacheName);
+        } else if (resp instanceof GetWebhookSecret.Error) {
+          throw new Error(`getWebhookSecret request failed: ${resp.message()}`);
         } else {
           throw new Error(
-            `getWebhookSecret request failed: ${(
-              resp as GetWebhookSecret.Error
-            ).message()}`
+            `unknown error occured when making a 'getWebhookSecret' request: ${resp.toString()}`
           );
         }
       });
     });
+    it('should create a new webhook, publish a message to a topic, and verify that the webhook was called', async () => {
+      const webhook = testWebhook(integrationTestCacheName);
+      await WithWebhook(topicClient, webhook, async () => {
+        const publishResp = await topicClient.publish(
+          webhook.id.cacheName,
+          webhook.topicName,
+          'a message'
+        );
+        if (publishResp instanceof TopicPublish.Error) {
+          throw new Error(
+            `failed to publish to topic: ${webhook.topicName} in cache: ${
+              webhook.id.cacheName
+            } webhook: ${
+              webhook.id.webhookName
+            } error: ${publishResp.toString()}`
+          );
+        }
+        // wait 5 seconds for webhook to get called. Can increase this if needed
+        await delay(5 * 1000);
+        const detes = await getWebhookRequestDetails(webhook.destination.url());
+        expect(detes.invocationCount).toBe(1);
+      });
+    });
   });
 }