refactor: short circuit response type checking in test

momentohq · Oct 12, 2024 · f2ab706 · f2ab706
1 parent aaa8cbb
commit f2ab706
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/packages/common-integration-tests/src/cache/replica-reads.ts b/packages/common-integration-tests/src/cache/replica-reads.ts
@@ -47,11 +47,9 @@ export function runReplicaReadTests(
             expect(getResponse).toBeInstanceOf(CacheGet.Hit);
           }, `expected HIT but got ${getResponse.toString()}`);
 
-          if (getResponse instanceof CacheGet.Hit) {
-            expectWithMessage(() => {
-              expect(getResponse.valueString()).toEqual(cacheValue);
-            }, `expected ${cacheValue} but got ${getResponse.valueString()}`);
-          }
+          expectWithMessage(() => {
+            expect(getResponse.value()).toEqual(cacheValue);
+          }, `expected ${cacheValue} but got ${getResponse.value() ?? 'undefined'}`);
         })();
         trials.push(trialPromise);
       }