chore: add leaderboards code snippets and example program #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anitarua
force-pushed
the
leaderboards-examples
branch
from
de28ad0 to
56ce800
Compare
cprice404
reviewed
Apr 10, 2024
examples/doc-examples-go-apis.go
Outdated
| panic(err) | ||
| } else { | ||
| switch r := getRankResponse.(type) { | ||
| case *responses.LeaderboardFetchSuccess: |
There was a problem hiding this comment.
what other types are available here? Or is it just Success?
Is this how we modeled other Fetch APIs? or are they like, Hit + Miss?
There was a problem hiding this comment.
There's only FetchSuccess, no Hit/Miss.
We'd waffled on Success/Error vs Found/NotFound/Error and settled on Success/Error after the bug bash: momentohq/client-sdk-javascript#966
pgautier404
reviewed
Apr 11, 2024
pgautier404
reviewed
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a leaderboard example file as well as dev docs code snippets for each leaderboard method