Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Locale#invalidDate #598

Merged
merged 1 commit into from
Oct 11, 2019

Conversation

camillef
Copy link
Contributor

@camillef camillef commented Oct 7, 2019

@@ -0,0 +1,27 @@
---
title: Invalid Date
version: 2.3.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see this functionality was introduced in moment/moment#1140 which was released in 2.3.0

moment.updateLocale("es", {
invalidDate: "Fecha invalida"
});
```
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example taken from moment/moment#4560

@marwahaha
Copy link
Member

Looks great, thanks!

@marwahaha marwahaha merged commit 575c1e7 into moment:master Oct 11, 2019
@camillef camillef deleted the customize-invalid-date branch October 14, 2019 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid date is not translated
2 participants