Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing moment-timezone to load in a web worker thread #78

Closed
wants to merge 3 commits into from

Conversation

milewis1
Copy link

@milewis1 milewis1 commented May 1, 2014

I recently tried to use moment-timezone in a web worker thread and found out it never got defined, because window is undefined in a web worker thread. To fix this I've added a case to allow moment-timezone to load in a web worker thread. I've tested this in both regular browser loading and in the web worker thread. I have not tested it with Node.js.

@ticky
Copy link

ticky commented May 7, 2014

As the minified version is in source control, you should run grunt uglify and amend your commit so the changes are reflected there.

@milewis1
Copy link
Author

milewis1 commented May 8, 2014

Thanks, I didn't take time to notice that. The commit has been amended.

@timrwood timrwood mentioned this pull request Jun 16, 2014
@timrwood
Copy link
Member

@milewis1 see #92 for an alternate solution.

@timrwood
Copy link
Member

Closing in favor of #92.

@timrwood timrwood closed this Jun 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants