Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Etc/UTC timezone recognition, updated tests #599

Merged
merged 2 commits into from
Apr 18, 2018
Merged

Conversation

ellenaua
Copy link
Contributor

@ellenaua ellenaua commented Apr 17, 2018

This is a fix for issue #598

Why issue happened

  • in 2017c unpacked data, "Etc/UTC" is going before "Etc/Universal" in array
  • in 2018d unpacked data, "Etc/Universal" is going before "Etc/UTC" in array
    Because of this, in 2017c packed data links are:
"Etc/UCT|UCT",
"Etc/UTC|Etc/Universal",
"Etc/UTC|Etc/Zulu",
"Etc/UTC|UTC",
"Etc/UTC|Universal",
"Etc/UTC|Zulu",

but in 2018d it linked this way:

"Etc/Universal|Etc/UTC",
"Etc/Universal|Etc/Zulu",
"Etc/Universal|UTC",
"Etc/Universal|Universal",
"Etc/Universal|Zulu",

This is a quick fix

Better fix should include these changes:

  • change findAndCreateLinks so that it does not depend on order of zones in unpacked array
  • improve tests, add makeTestGuess for each timezone (it was missing for Etc/UTC)

I'll provide a better fix in a few days

@ellenaua ellenaua changed the title Etc/UTC bugfix Fixed Etc/UTC timezone recognition, updated tests Apr 18, 2018
@ellenaua ellenaua force-pushed the etc-utc-bugfix branch 6 times, most recently from 6135f4f to fc34187 Compare April 18, 2018 02:00
@ellenaua ellenaua merged commit 63b7ad9 into develop Apr 18, 2018
@ellenaua ellenaua deleted the etc-utc-bugfix branch October 12, 2019 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant