Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer moment.fn.utcOffset to moment.fn.zone #168

Merged
merged 4 commits into from
Dec 19, 2014
Merged

Prefer moment.fn.utcOffset to moment.fn.zone #168

merged 4 commits into from
Dec 19, 2014

Conversation

timrwood
Copy link
Member

Corresponding moment issue: moment/moment#2074

timrwood added a commit that referenced this pull request Dec 19, 2014
Prefer moment.fn.utcOffset to moment.fn.zone
@timrwood timrwood merged commit 7a6f7f1 into develop Dec 19, 2014
@timrwood timrwood deleted the utc-offset branch December 19, 2014 18:49
@ItalyPaleAle
Copy link

Next time, it would be nice to support the principles of semver, though. APIs should not change from 0.2.4 to 0.2.5.

@timrwood
Copy link
Member Author

@EgoAleSum, this was a deprecation from moment core. I believe moment.fn.zone will be supported until moment 3.0 according to semver.

This does not change the moment-timezone public api though, so semver doesn't really have anything to do with this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants