Add tests around DateTime.toISO() #752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icambron
approved these changes
Aug 19, 2020
icambron
added a commit
that referenced
this pull request
Sep 28, 2020
* remove console.log call and bump to 1.24.1 * update package-lock.json * fix Interval.hasSame behaviour for empty intervals (#712) Fixes #709 * Mark the package as side-effects-free (#713) Addresses #710 * Add DATE_MED_WITH_WEEKDAY preset (#716) * All tests assume America/NewYork timezone (#718) * Add missing values in conversion matrices (#720) * Remove normalization in ShiftTo (#721) * RelativeTime test fails on last day of the month (#719) * Update wording around date equality test (#725) * Update wording around date equality test As discussed in #108 * Fix for negative values in plus/minus. Fixes #645 and #669 (#722) Requires the `fullConversionMatrices` and `noNormalizationInShiftTo` branches to be merged first. * Fixed typos in docs where 'month' was used in place of 'weekday' (#732) * feat: add support for large durations in seconds (#737) * Bump lodash from 4.17.14 to 4.17.19 (#739) Bumps [lodash](https://github.com/lodash/lodash) from 4.17.14 to 4.17.19. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.14...4.17.19) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Interval creation supports Settings.throwOnInvalid. Fixes #728 (#761) * formatOffset handles signed offsets. Fixes #665 (#756) * Update package-lock.json after npm install (#751) Co-authored-by: Gilles Debunne <[email protected]> * Add tests around DateTime.toISO() (#752) * Round minutes in timezone offset display. Fixes #724 (#755) * Support arbitrary precision in ISO milliseconds. Fixes #757 (#758) * Support arbitrary precision in ISO milliseconds. Fixes #757 * Limit regex to 30 digits to prevent DOS * fromFormat handles non breakable spaces. Fixes #714 (#762) * Update Why page, remove outdated Relative references. Fixes #679. (#765) * bump to 1.25.0 * Introduce DateTime.now() (#766) * Bump codecov from 3.6.5 to 3.7.1 (#744) Bumps [codecov](https://github.com/codecov/codecov-node) from 3.6.5 to 3.7.1. - [Release notes](https://github.com/codecov/codecov-node/releases) - [Commits](codecov/codecov-node@v3.6.5...v3.7.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update endOf() documentation with the same units as startOf() (#779) * UnitFormat was folded into Unified NumberFormat (#785) As per tc39/ecma402#32 (comment) Co-authored-by: Isaac Cambron <[email protected]> Co-authored-by: downace <[email protected]> Co-authored-by: Ryota Kameoka <[email protected]> Co-authored-by: saltire <[email protected]> Co-authored-by: Jon Knowles <[email protected]> Co-authored-by: Jörg Bayreuther <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Gilles Debunne <[email protected]> Co-authored-by: Anthon Holmqvist <[email protected]> Co-authored-by: Bart Enkelaar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added these tests since I realized this behavior is probably broken in the
tsdxbranch, and these tests would have caught the error.