preserve language tags #1354
preserve language tags #1354
Conversation
|
|
devsnek
force-pushed
the
language-tags
branch
from
3511882
to
046998a
Compare
|
This is unfortunately not correct when the language tag contains a private use subtag ( |
src/impl/locale.js
Outdated
| @@ -75,22 +75,26 @@ function parseLocaleString(localeStr) { | |||
| return [localeStr]; | |||
| } else { | |||
| let options; | |||
| let selectedStr; | |||
| const smaller = localeStr.substring(0, uIndex); | |||
There was a problem hiding this comment.
You can now move this substring into the catch. It was only outside of it because we used it in the return.
| @@ -695,7 +695,7 @@ test("DateTime.fromObject overrides the locale string with explicit settings", ( | |||
| } | |||
| ); | |||
|
|
|||
| expect(res.locale).toBe("be"); | |||
| expect(res.locale).toBe("be-u-ca-coptic-nu-mong"); | |||
| expect(res.outputCalendar).toBe("islamic"); | |||
| expect(res.numberingSystem).toBe("thai"); | |||
| }); | |||
There was a problem hiding this comment.
Can you also add a test here where you set the locale to something with a calendar and an explicit outputCalendar and show that it doesn't blow up (I don't care which calendar "wins", but the test should document the result, i.e. which calendar comes out of the resolved options)
There was a problem hiding this comment.
i think this is that test?
|
@diesieben07 do you have any suggestion for what should be done? Does this need to support private use subtags? |
You could either detect the
Probably not. But currently this code is a regression, because previously they were just ignored and now they cause the Edit: I just want to clarify, that I am not a maintainer for this project, so I do not have any decision power here! |
|
Looks good. Thanks! |
Fixes: #1335