Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use upload-artifact v4 since v3 is not compatible with download-artifact v4 #369

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

geertjanvdenbosch
Copy link
Collaborator

Recently, dependabot upgraded download-artifact to v4 #365.

This is causing issues when publishing the package to pypi, because this download-artifact version is incompatible with upload-artifact v3. (https://github.com/actions/toolkit/blob/main/packages/artifact/docs/faq.md#which-versions-of-the-artifacts-packages-are-compatible)

This PR upgrades upload-artifact to v4, as well as the checkout action.

Copy link
Collaborator

@Thomasvdh92 Thomasvdh92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Thomasvdh92 Thomasvdh92 merged commit f7fab9f into master Nov 5, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants