Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Virtual & download product Support #68

Closed
beendeluxe opened this issue Sep 27, 2023 · 2 comments
Closed

[FEATURE] Virtual & download product Support #68

beendeluxe opened this issue Sep 27, 2023 · 2 comments

Comments

@beendeluxe
Copy link

We are using Magento 2.4.5-p4 and tested the Mollie subscription integration. Its working well for phsysical products. Its simple but effective.

But... we are facing an error when things go beyond physical products. When for example selling a digital product or a downloadable (digital) product that does not require any shipping method, the extension throws an exception error;
main.CRITICAL: Error: Call to a member function setQuote() on null in /vendor/mollie/magento2-subscriptions/Service/Mollie/GetShippingCostForOrderItem.php:100

That means that the extension requires any shipping method to go ahead.

Is this already a known bug? We would be happy if this module could also handle digital products.

Thanks.

@Frank-Magmodules
Copy link
Collaborator

Hello @beendeluxe, we appreciate you submitting your feature request. We have added it to our feature request list and will update you as soon as we have more information regarding its potential release.

@Frank-Magmodules Frank-Magmodules changed the title Issue: Mollie subscriptions throws Exception error on virtual & download products [FEATURE] Vrtual & download product Support Sep 28, 2023
@Frank-Magmodules Frank-Magmodules changed the title [FEATURE] Vrtual & download product Support [FEATURE] Virtual & download product Support Sep 28, 2023
michielgerritsen added a commit to michielgerritsen/magento2-subscriptions that referenced this issue Oct 17, 2023
@beendeluxe
Copy link
Author

The merge works like a charm. Thanks for this quick fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants