Fix/company billie #971
Open
Fix/company billie #971
+69
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Narek13
reviewed
Dec 24, 2024
| @@ -6,7 +6,7 @@ | |||
|
|
|||
| class BillieFieldsStrategy implements PaymentFieldsStrategyI | |||
| { | |||
| const FIELD_COMPANY = "billing_company"; | |||
| const FIELD_COMPANY = "billing_company_billie"; | |||
There was a problem hiding this comment.
It is recommended to use the single quotes for the simple strings, also can add the visibility to constant.
Suggested change
| const FIELD_COMPANY = "billing_company_billie"; | |
| public const FIELD_COMPANY = 'billing_company_billie'; |
Narek13
reviewed
Dec 24, 2024
| return $this->addPaymentMethodMandatoryFields($fields, $gatewayName, $field, $companyLabel, $errors); | ||
| } | ||
|
|
||
| public function switchFields($data) |
There was a problem hiding this comment.
is it because of the interface that most of the methods here don't use type hints or return types?
Narek13
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
handles PIWOO-575