Feature/apple express piwoo 319 #949
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added css for the button added in cart and checkout block
inpsyde-maticluznar
requested changes
Oct 11, 2024
| @@ -3,6 +3,8 @@ | |||
| } | |||
| .apple-pay-button { | |||
| display: inline-block; | |||
| width: 100%; | |||
| height: 41px; | |||
There was a problem hiding this comment.
Is there a reason to set the button height?
There was a problem hiding this comment.
I think now i understood better the requirements of the button styling, but let me know if you see way to improve.
inpsyde-maticluznar
approved these changes
Oct 15, 2024
inpsyde-maticluznar
requested changes
Oct 17, 2024
| @@ -49,21 +49,24 @@ import ApplePayButtonComponent from './blocks/ApplePayButtonComponent' | |||
| gatewayData.forEach(item => { | |||
| let register = () => registerPaymentMethod(molliePaymentMethod(useEffect, ajaxUrl, filters, gatewayData, availableGateways, item, jQuery, requiredFields, isCompanyFieldVisible, isPhoneFieldVisible)); | |||
| if (item.name === 'mollie_wc_gateway_applepay' && !isBlockEditor) { | |||
| const isExpressEnabled = item.isExpressEnabled; | |||
There was a problem hiding this comment.
If a new variable has the same name as the object property, you can do just that:
const {isExpressEnabled} = item;
Comment on lines
+61
to
+62
| content: < ApplePayButtonComponent />, | ||
| edit: < ApplePayButtonComponent />, |
There was a problem hiding this comment.
This extra space can cause problems. Do these components still work?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles PIWOO-319