Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/piwoo 350 twint method #868

Merged
merged 5 commits into from
Jan 29, 2024
Merged

Feature/piwoo 350 twint method #868

merged 5 commits into from
Jan 29, 2024

Conversation

mmaymo
Copy link
Collaborator

@mmaymo mmaymo commented Dec 18, 2023 •
edited by jira bot
Loading

Handles PIWOO-350

inpsyde-maticluznar
inpsyde-maticluznar requested changes Dec 19, 2023
View reviewed changes
Copy link
Collaborator

@inpsyde-maticluznar inpsyde-maticluznar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that all of the comments are just an assumption. Please review them, and decide if there is something to fix or not.

For future tasks we will have to be more consistent with using camelCase instead of snake_case, and maybe fix that someday.

src/Shared/Data.php Outdated Show resolved Hide resolved
src/Shared/Data.php Outdated Show resolved Hide resolved
src/Shared/Data.php Outdated Show resolved Hide resolved
src/Shared/Data.php Outdated Show resolved Hide resolved
@mmaymo mmaymo merged commit 00ca2e2 into develop Jan 29, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inpsyde-maticluznar inpsyde-maticluznar inpsyde-maticluznar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmaymo @inpsyde-maticluznar